Comments on: Coding Sample

By: Dom

Dom — Thu, 14 Apr 2011 02:44:38 +0000

@HarryMuff: I tend to code with an eye toward the actual language itself. If you’re coding in PHP, don’t try to shoehorn in “real” programming languages, as you term them. When you only have a hammer, every problem looks like a nail.

Fortunately, my tool box isn’t as bare.

By: Dom

Dom — Thu, 14 Apr 2011 02:42:34 +0000

Semantics, on the integer/strings because it’s in the comments for readability by another (future) coder. PHP doesn’t have strong typing — if this were C++ or a C derivative, I would have certainly made sure the variable typing was specific to the language. I’m not a fan of needless (and in PHP, unnecessary) complexity. I guess that’s part of what separates me from the pack.

I don’t see where you’re saying $returnText isn’t defined. If you’re new at reading code, look toward the top of the class, where it’s defined as a public variable for the methods to use.

By: Fred

Fred — Thu, 10 Mar 2011 23:09:31 +0000

You never actually define $returnText before appending data to it.

You are also relying on Type Juggling in PHP for comparison in your switch. You specify in your comments that it’s expecting an integer, but your switching is testing for strings.

By: HarryMuff

HarryMuff — Sat, 22 Jan 2011 09:07:52 +0000

Public variable? Where’s the encapsulation? You are using a class and making objects of that class right? If so you forgot one of the most important parts of object oriented programming. Unless you are using this class statically – in which case it’s still coded wrong.
No offense but it looks like you learned to program using PHP instead of a real programming language.